Fix number of layers check#115
Merged
Merged
Conversation
bradh
force-pushed
the
layers_100_2025-12-03
branch
from
3731dd8 to
09c05b3
Compare
bradh
force-pushed
the
layers_100_2025-12-03
branch
from
09c05b3 to
11bcc1e
Compare
scaramallion
approved these changes
Dec 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The number of layers supported is later checked as > 100:
https://github.com/bradh/pylibjpeg-openjpeg/blob/590e4316fc9ae373775ea843a7399ce03d05e37a/lib/interface/encode.c#L245
and
https://github.com/bradh/pylibjpeg-openjpeg/blob/590e4316fc9ae373775ea843a7399ce03d05e37a/lib/interface/encode.c#L274
This makes the wrapper code consistent.
The profile I'm targeting requires 20 layers.